[Qemu-commits] [qemu/qemu] 80e354: hw/x86: add a couple of comments explaining how th...

[Richard Henderson]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 80e3541282af347538a37ee0673bcc04c622ad1c
      
https://github.com/qemu/qemu/commit/80e3541282af347538a37ee0673bcc04c622ad1c
  Author: Ani Sinha <anisinha@redhat.com>
  Date:   2024-08-23 (Fri, 23 Aug 2024)

  Changed paths:
    M hw/i386/x86-common.c

  Log Message:
  -----------
  hw/x86: add a couple of comments explaining how the kernel image is parsed

Cosmetic: add comments in x86_load_linux() pointing to the kernel documentation
so that users can better understand the code.

CC: qemu-trivial@nongnu.org
Signed-off-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: d53bb908b552df11f4ac5541ec133ef4123fc0ca
      
https://github.com/qemu/qemu/commit/d53bb908b552df11f4ac5541ec133ef4123fc0ca
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-08-23 (Fri, 23 Aug 2024)

  Changed paths:
    M system/vl.c

  Log Message:
  -----------
  system/vl.c: Print machine name, not "(null)", for unknown machine types

In commit 412d294ffdc we tried to improve the error message printed when
the machine type is unknown, but we used the wrong variable, resulting in:

$ ./build/x86/qemu-system-aarch64 -M bang
qemu-system-aarch64: unsupported machine type: "(null)"
Use -machine help to list supported machines

Use the right variable, so we produce more helpful output:

$ ./build/x86/qemu-system-aarch64 -M bang
qemu-system-aarch64: unsupported machine type: "bang"
Use -machine help to list supported machines

Note that we must move the qdict_del() to below the error_setg(),
because machine_type points into the value of that qdict entry,
and deleting it will make the pointer invalid.

Cc: qemu-stable@nongnu.org
Fixes: 412d294ffdc ("vl.c: select_machine(): add selected machine type to error 
message")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: d6192f3f7593536a4285e8ab6c6cf3f34973ce62
      
https://github.com/qemu/qemu/commit/d6192f3f7593536a4285e8ab6c6cf3f34973ce62
  Author: Haoran Zhang <wh1sper@zju.edu.cn>
  Date:   2024-08-23 (Fri, 23 Aug 2024)

  Changed paths:
    M hw/display/vhost-user-gpu.c

  Log Message:
  -----------
  hw/display/vhost-user-gpu.c: fix vhost_user_gpu_chr_read()

fix vhost_user_gpu_chr_read() where `size` was incorrectly passed to 
`msg->flags`.

Fixes: 267f664658 ("hw/display: add vhost-user-vga & gpu-pci")
Signed-off-by: Haoran Zhang <wh1sper@zju.edu.cn>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: f259e4cb8a8b4ef5463326fc214a7d8d7703d5de
      
https://github.com/qemu/qemu/commit/f259e4cb8a8b4ef5463326fc214a7d8d7703d5de
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-08-24 (Sat, 24 Aug 2024)

  Changed paths:
    M hw/display/vhost-user-gpu.c
    M hw/i386/x86-common.c
    M system/vl.c

  Log Message:
  -----------
  Merge tag 'pull-trivial-patches' of https://gitlab.com/mjt0k/qemu into staging

trivial patches for 2024-08-23

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCAAdFiEEe3O61ovnosKJMUsicBtPaxppPlkFAmbImVIACgkQcBtPaxpp
# PllP3wf/TaYAQs0HkQRQ62/2wqnfABpZYft/g6EhHveZ/04pJ/eNIIiVqqUg4DGs
# i8fENABRlRPoeK5HtGVhHYbOg6tzje7MR0qdSmWaKb2R5pPqkLHZ6NTtQlINLpOb
# O8Nh1c5/qDW/pDPCWVLkEMTqKhtGfINr0pHSlTfOr0W9FrU1I6srvr6AZtrTORlL
# 5b79j5IZGQSj5zR3ViuKyEPdA5NRSeTOewg8WCKGSxZGk4OlVPevrEAGOyQReOuN
# HTfNi8KQH/pPzl6+f+THkgKmYYfUAlPvzkJDndV9vcPFLPI8ZncZ1o1Kmog6UERc
# s5J2vTcir/ReEukApRRsZkKHLAoYdQ==
# =Srl8
# -----END PGP SIGNATURE-----
# gpg: Signature made Sat 24 Aug 2024 12:14:42 AM AEST
# gpg:                using RSA key 7B73BAD68BE7A2C289314B22701B4F6B1A693E59
# gpg: Good signature from "Michael Tokarev <mjt@tls.msk.ru>" [full]
# gpg:                 aka "Michael Tokarev <mjt@debian.org>" [full]
# gpg:                 aka "Michael Tokarev <mjt@corpit.ru>" [full]

* tag 'pull-trivial-patches' of https://gitlab.com/mjt0k/qemu:
  hw/display/vhost-user-gpu.c: fix vhost_user_gpu_chr_read()
  system/vl.c: Print machine name, not "(null)", for unknown machine types
  hw/x86: add a couple of comments explaining how the kernel image is parsed

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/407f9a4b121e...f259e4cb8a8b

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications