[Qemu-commits] [qemu/qemu] b1ea47: configure, meson: synchronize defaults for configu...

[Paolo Bonzini]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: b1ea47127e02521284bf64f706647812b72dc5f6
      
https://github.com/qemu/qemu/commit/b1ea47127e02521284bf64f706647812b72dc5f6
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
    M configure
    M meson_options.txt

  Log Message:
  -----------
  configure, meson: synchronize defaults for configure and Meson Rust options

If the defaults for --enable-rust ($rust in configure) and Meson's rust
option are out of sync, incremental builds will pick Meson's default.

This happens because, on an incremental build, configure does not run
Meson, Make does instead.  Meson then gets the command line options
from either coredata.dat (which has everything cached in Python's pickle
format) or cmd_line.txt (slow path when Meson version is upgraded), but
neither knows about the rust option, and the meson_options.txt default
is used.

This will cause have_rust to be true if rustc is available; and the build
to fail because configure did not put a RUST_TARGET_TRIPLE in config-host.mak.

When in the Rust pull request I changed the $rust default from auto
to disabled, I should have made the same change to meson_options.txt;
do it now.

Cc: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20241014110113.173946-1-pbonzini@redhat.com
Tested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>



To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications