Re: [Qemu-devel] Can you commit the pcnet patch ?

[Christian MICHON]

When I try to replace bcmp (inexistant in mingw32) with memcmp
inside pcnet.h, like this:

int result = (!CSR_DRCVPA(s)) && !bcmp(hdr->ether_dhost, padr, 6);

into 

int result = (!CSR_DRCVPA(s)) && !bcmp(hdr->ether_dhost, padr, 6);

I get the following error:
In file included from C:/dev/msys/1.0/home/xian/qemu-0.7.0/hw/pcnet.c:64:
C:/dev/msys/1.0/home/xian/qemu-0.7.0/hw/pcnet.h: In function `padr_match':
C:/dev/msys/1.0/home/xian/qemu-0.7.0/hw/pcnet.h:531: error:
dereferencing pointer to incomplete type

anyone having a fix. I'm quite puzzled by the gcc error message.

Thx
Christian

=============================================
static inline int padr_match(PCNetState *s, const uint8_t *buf, int size)
{
    struct ether_header *hdr = (void *)buf;
    uint8_t padr[6] = { 
        s->csr[12] & 0xff, s->csr[12] >> 8,
        s->csr[13] & 0xff, s->csr[13] >> 8,
        s->csr[14] & 0xff, s->csr[14] >> 8 
    };
int result = (!CSR_DRCVPA(s)) && !memcmp(hdr->ether_dhost, padr, 6);

for better understanding of the faulty piece of code