Re: [Qemu-devel] [PATCH] Add parallel memory mapped interface

[Paul Brook]

On Wednesday 06 June 2007, Blue Swirl wrote:
> On 6/6/07, Hervé Poussineau <address@hidden> wrote:
> > Hi,
> >
> > This patch adds a memory-mapped interface to the parallel port emulation.
> > It is not as complete as I/O interface (no EPP/ECP), but I didn't want to
> > add lots of code for very little use.
> > It also cleans up indentation of the file (replaces tabulations by four
> > spaces)

IMHO it's a bad idea to combine writespace cleanups with actual changes.
It makes the patch much larger and more confusing than it needs to be.

> Please don't use target_ulong in device drivers, but
> target_phys_addr_t for physical addresses. I don't know about IO
> addresses, uint32_t?

"int" is appropriate for IO port addresses.
This is what the register_ioport_{read,write} routines use.

Paul