Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

[Anthony Liguori]

On 01/05/2010 11:16 AM, Amit Shah wrote:
> > > +static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent)
> > > +{
> > > +    VirtIOSerialDevice *dev = DO_UPCAST(VirtIOSerialDevice, qdev, qdev);
> > > +    VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev,&dev->qdev);
> > > +
> > > +    monitor_printf(mon, "%*s dev-prop-int: id: %u\n",
> > > +                   indent, "", port->id);
> > > +    monitor_printf(mon, "%*s dev-prop-int: is_console: %d\n",
> > > +                   indent, "", port->is_console);
> > > +}
> > >
> > >        
> > This will break the build since it's not referenced anywhere.
> >      
> Again, as mentioned in the other thread, it gets used here:
>
> static struct BusInfo virtser_bus_info = {
>      .name      = "virtio-serial-bus",
>      .size      = sizeof(VirtIOSerialBus),
>      .print_dev = virtser_bus_dev_print,
> };
>
> (I've compile- and run- tested these patches.)
>    

Okay.

>                 Amit
>