qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [STABLE 0.12] QMP: Drop wrong assert()


From: Anthony Liguori
Subject: Re: [Qemu-devel] [STABLE 0.12] QMP: Drop wrong assert()
Date: Fri, 08 Jan 2010 10:34:17 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 12/21/2009 09:09 PM, Luiz Capitulino wrote:
Some commands return a QList of QDicts, which is valid,
but will trig the assert().

Just drop it.

Reported-by: Nathan Baum<address@hidden>
Signed-off-by: Luiz Capitulino<address@hidden>

Applied.  Thanks.

Regards,

Anthony Liguori

---
  monitor.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/monitor.c b/monitor.c
index c0dc48e..3af1d5c 100644
--- a/monitor.c
+++ b/monitor.c
@@ -283,7 +283,6 @@ static void monitor_protocol_emitter(Monitor *mon, QObject 
*data)
      if (!monitor_has_error(mon)) {
          /* success response */
          if (data) {
-            assert(qobject_type(data) == QTYPE_QDICT);
              qobject_incref(data);
              qdict_put_obj(qmp, "return", data);
          } else {





reply via email to

[Prev in Thread] Current Thread [Next in Thread]