[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] block: clean up bdrv_open2 structure a bit
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] block: clean up bdrv_open2 structure a bit |
|
Date: |
Tue, 12 Jan 2010 18:14:58 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 |
Am 12.01.2010 18:09, schrieb Christoph Hellwig:
> On Tue, Jan 12, 2010 at 05:04:00PM +0100, Kevin Wolf wrote:
>> To keep the behaviour as previously you'd need to set at least bs->drv
>> in the unlink_and_fail case, too. I have no clue why it's important to
>> set it to NULL when bs isn't going to be used anyway (probably it is,
>> but I don't know where), but Fabrice committed this in 6b21b973 as a
>> fix. Unfortunately, the commit message looks like most of Fabrice's
>> commit messages, so it's of no use for me...
>
> The unlink_and_fail label can only be reached from places where we
> haven't set bs->drv yet, so it should be fine.
Sorry, I confused drv and bs->drv. Looks alright then.
Acked-by: Kevin Wolf <address@hidden>