Re: [Qemu-devel] [PATCH 4/9] PPC: Include dump of lspci -nn on real G5

[Blue Swirl]

On Tue, Jan 12, 2010 at 8:35 PM, Alexander Graf <address@hidden> wrote:
>
> On 12.01.2010, at 21:16, Blue Swirl wrote:
>
>> On Tue, Jan 12, 2010 at 11:58 AM, Alexander Graf <address@hidden> wrote:
>>> To ease debugging and to know what we're lacking, I found it really useful 
>>> to
>>> have an lspci dump of a real U3 based G5 around. So I added a comment for 
>>> it.
>>>
>>> If people don't think it's important enough to include this information in 
>>> the
>>> sources, just don't apply this patch.
>>
>> I think it would be useful, but the right place would be in
>> ppc_newworld.c, because that is where the PCI bus is populated.
>
> Hum, that file is pretty cluttered already. How about we create a 
> Documentation subdir in qemu that contains information about various devices?

Nobody reads documentation :) There's plenty of room near line 50,
that's where I have put references in other files.

>> For unin_pci.c, an interesting reference would be a link to the data sheet.
>
> I'm not aware of any. The only real specification I know of is for the U4.

Then U4 may be a more interesting machine to be implemented than U3,
at least if there are more documented devices or fewer critical
undocumented devices.