[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv7 3/3] virtio: add features as qdev properties
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCHv7 3/3] virtio: add features as qdev properties |
|
Date: |
Tue, 12 Jan 2010 23:06:33 +0100 |
|
User-agent: |
Mutt/1.3.28i |
On Tue, Jan 12, 2010 at 09:50:55PM +0200, Michael S. Tsirkin wrote:
> So the issue is that wrong block size (0xffffffff) was passed
> to guest. Would it make sense to add some sanity checking in virtio-blk
> to make it not crash but fail in probe? Which block size values
> are sane?
Yes, I'll cook up a patch. Basically powers of two up from 512 bytes
are theoretically sane. In practice I doubt we'll ever see anything
other than 512 or 4095 bytes.