[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/8] VNC: Add 'family' key
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 4/8] VNC: Add 'family' key |
Date: |
Fri, 15 Jan 2010 09:54:13 -0200 |
On Fri, 15 Jan 2010 08:54:56 +0100
Gerd Hoffmann <address@hidden> wrote:
> > +static QString *get_sock_family(const struct sockaddr_storage *sa)
> > +{
> > + const char *name;
> > +
> > + switch (sa->ss_family)
> > + {
> > + case AF_INET:
> > + name = "ipv4";
> > + break;
> > + case AF_INET6:
> > + name = "ipv6";
> > + break;
> > + default:
> > + name = "unknown";
> > + break;
> > + }
> > +
> > + return qstring_from_str(name);
> > +}
>
> qemu-socket has inet_strfamily() already. You might want to un-static
> that one, then simply do
>
> return qstring_from_str(inet_strfamily(sa->ss_family));
Will do and resend.
Thanks Gerd.
- [Qemu-devel] [PATCH v0 0/8]: VNC events and cleanup, Luiz Capitulino, 2010/01/14
- [Qemu-devel] [PATCH 1/8] VNC: Use 'enabled' key instead of 'status', Luiz Capitulino, 2010/01/14
- [Qemu-devel] [PATCH 2/8] VNC: Make 'auth' key mandatory, Luiz Capitulino, 2010/01/14
- [Qemu-devel] [PATCH 3/8] VNC: Rename client's 'username' key, Luiz Capitulino, 2010/01/14
- [Qemu-devel] [PATCH 4/8] VNC: Add 'family' key, Luiz Capitulino, 2010/01/14
- [Qemu-devel] [PATCH 5/8] VNC: Cache client info at connection time, Luiz Capitulino, 2010/01/14
- [Qemu-devel] [PATCH 6/8] QMP: Introduce VNC_CONNECTED event, Luiz Capitulino, 2010/01/14
- [Qemu-devel] [PATCH 8/8] QMP: Introduce VNC_INITIALIZED event, Luiz Capitulino, 2010/01/14
- [Qemu-devel] [PATCH 7/8] QMP: Introduce VNC_DISCONNECTED event, Luiz Capitulino, 2010/01/14
- [Qemu-devel] Re: [PATCH v0 0/8]: VNC events and cleanup, Daniel P. Berrange, 2010/01/14