qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] char: Remove redundant qemu_chr_generic_open()


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] char: Remove redundant qemu_chr_generic_open() call.
Date: Tue, 19 Jan 2010 16:38:57 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 01/14/2010 09:46 AM, Kusanagi Kouichi wrote:
qemu_chr_open_fd() calls qemu_chr_generic_open(),
so qemu_chr_open_tty() doesn't need to call it.

Signed-off-by: Kusanagi Kouichi<address@hidden>

Applied.  Thanks.

Regards,

Anthony Liguori
---
  qemu-char.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/qemu-char.c b/qemu-char.c
index b13f8d4..800ee6c 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1187,7 +1187,6 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
          return NULL;
      }
      chr->chr_ioctl = tty_serial_ioctl;
-    qemu_chr_generic_open(chr);
      return chr;
  }
  #else  /* ! __linux__&&  ! __sun__ */





reply via email to

[Prev in Thread] Current Thread [Next in Thread]