[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: Stop using "which" in ./configure
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: Stop using "which" in ./configure |
Date: |
Thu, 21 Jan 2010 10:48:54 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Loïc Minier <address@hidden> wrote:
> On Wed, Jan 20, 2010, Måns Rullgård wrote:
>> If you make that IFS=${local_ifs:-$(printf ' \t\n')} it should be safe.
>> Likewise if you set the value first.
>
> Ok; see attached patches
I still think that path_of is a complication that we don't really need.
"type" command exist in posix, and althought its output is not defined,
if the output of a real command don't show the path that we need (in
this case /usr/bin/install), then type is pretty wrong in my humble
opinion.
With respect of the rest of the patch. Only real difference is that
mine uses "prog_exists" vs yours use "has" name.
I obviosly think that prog_exists is a more descriptive name, but I
really don't care one way or another.
Can we agree that we don't need path_of, and then just stop playing with
IFS and friends?
Later, Juan.
- Re: [Qemu-devel] Stop using "which" in ./configure, (continued)
- [Qemu-devel] Re: Stop using "which" in ./configure, Måns Rullgård, 2010/01/19
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/20
- [Qemu-devel] Re: Stop using "which" in ./configure, Paolo Bonzini, 2010/01/20
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/20
- [Qemu-devel] Re: Stop using "which" in ./configure, Paolo Bonzini, 2010/01/20
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/20
- [Qemu-devel] Re: Stop using "which" in ./configure, Måns Rullgård, 2010/01/20
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/21
- [Qemu-devel] Re: Stop using "which" in ./configure,
Juan Quintela <=
- [Qemu-devel] Re: Stop using "which" in ./configure, Måns Rullgård, 2010/01/21
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/26
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Blue Swirl, 2010/01/26
- [Qemu-devel] [PATCH 1/3] Check for sdl-config before calling it, Loïc Minier, 2010/01/27
- [Qemu-devel] [PATCH 2/3] Add and use has() and path_of() funcs, Loïc Minier, 2010/01/27
- [Qemu-devel] [PATCH 3/3] Solaris: test for presence of commands with has(), Loïc Minier, 2010/01/27
- Re: [Qemu-devel] [PATCH 1/3] Check for sdl-config before calling it, Ben Taylor, 2010/01/27
- [Qemu-devel] Re: [PATCH 1/3] Check for sdl-config before calling it, Paolo Bonzini, 2010/01/27
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/27
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Blue Swirl, 2010/01/27