[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 17/17] mmap_frag() users only check for -1 erro
From: |
Laurent Desnogues |
Subject: |
Re: [Qemu-devel] [PATCH 17/17] mmap_frag() users only check for -1 error |
Date: |
Mon, 25 Jan 2010 09:53:03 +0100 |
On Wed, Jan 20, 2010 at 9:14 PM, Juan Quintela <address@hidden> wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> linux-user/mmap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
> index c1c7e48..25fc0b2 100644
> --- a/linux-user/mmap.c
> +++ b/linux-user/mmap.c
> @@ -243,7 +243,7 @@ static int mmap_frag(abi_ulong real_start,
> possible while it is a shared mapping */
> if ((flags & MAP_TYPE) == MAP_SHARED &&
> (prot & PROT_WRITE))
> - return -EINVAL;
> + return -1;
>
> /* adjust protection to be able to read */
> if (!(prot1 & PROT_WRITE))
Looks good to me, but a similar patch is needed for
bsd-user/mmap.c and darwin-user/mmap.c.
Laurent
- [Qemu-devel] [PATCH 08/17] block/qcow2.c: fix warnings with _FORTIFY_SOURCE, (continued)
- [Qemu-devel] [PATCH 08/17] block/qcow2.c: fix warnings with _FORTIFY_SOURCE, Juan Quintela, 2010/01/20
- [Qemu-devel] [PATCH 10/17] usb-linux.c: fix warning with _FORTIFY_SOURCE, Juan Quintela, 2010/01/20
- [Qemu-devel] [PATCH 09/17] net/slirp.c: fix warning with _FORTIFY_SOURCE, Juan Quintela, 2010/01/20
- [Qemu-devel] [PATCH 11/17] vl.c: fix warning with _FORTIFY_SOURCE, Juan Quintela, 2010/01/20
- [Qemu-devel] [PATCH 12/17] monitor.c: fix warnings with _FORTIFY_SOURCE, Juan Quintela, 2010/01/20
- [Qemu-devel] [PATCH 13/17] linux-user/mmap.c: fix warnings with _FORTIFY_SOURCE, Juan Quintela, 2010/01/20
- [Qemu-devel] [PATCH 15/17] Enable _FORTIFY_SOURCE=2, Juan Quintela, 2010/01/20
- [Qemu-devel] [PATCH 14/17] check pipe() return value, Juan Quintela, 2010/01/20
- [Qemu-devel] [PATCH 16/17] Check availavility of -fstack-protector-all, Juan Quintela, 2010/01/20
- [Qemu-devel] [PATCH 17/17] mmap_frag() users only check for -1 error, Juan Quintela, 2010/01/20
- Re: [Qemu-devel] [PATCH 17/17] mmap_frag() users only check for -1 error,
Laurent Desnogues <=