|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCH 4/6] vnc.c: warn about ignored option |
Date: | Wed, 27 Jan 2010 11:00:05 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 |
On 01/27/10 03:10, Anthony Liguori wrote:
On 01/26/2010 05:14 PM, Paolo Bonzini wrote:Signed-off-by: Paolo Bonzini<address@hidden> --- vnc.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/vnc.c b/vnc.c index cc2a26e..9ebee09 100644 --- a/vnc.c +++ b/vnc.c @@ -2563,6 +2563,7 @@ int vnc_display_open(DisplayState *ds, const char *display) reverse = 1; } else if (strncmp(options, "to=", 3) == 0) { to_port = atoi(options+3) + 5900; + fprintf(stderr, "qemu: warning: to= option for -vnc ignored\n");If we're ignoring it, why even have the code? How did clang spot this?
to= isn't ignored. The to= handling has been moved to qemu-socket.c though a while ago. So clang spotted correctly that to_port variable is unused. The whole 'if (...) {}' is a leftover which can go away now.
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |