[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: future of the virtio-blk serial number support
From: |
john cooper |
Subject: |
[Qemu-devel] Re: future of the virtio-blk serial number support |
Date: |
Thu, 28 Jan 2010 11:38:47 -0500 |
User-agent: |
Thunderbird 2.0.0.9 (X11/20071115) |
Christoph Hellwig wrote:
> Back iSeptember 2007 Michael made the serial number support in qemu
> optional and off by default, and in October 2009 Rusty reverted the
> Linux virtio-blk support for it. Given that I can't find support in
> any other virtio implementation that makes the feature look essentially
> dead.
>
> How should we proceed with adding more fields to struct virtio_blk_config?
> I would suggest removing the identity field, declaring
> VIRTIO_BLK_F_IDENTIFY officially deprecated and adding the new fields
> directly after blk_size again, maybe with a comment that these new
> features can't be advertized together with VIRTIO_BLK_F_IDENTIFY.
Agreed. Feel free to remove it from the PCI
config space. Its an artifact at this point
and I wouldn't even worry about deprecating
it.
-john
--
address@hidden