[Qemu-devel] Re: [PATCH 1/7] Add support for generic notifier lists

[Paolo Bonzini]

On 03/11/2010 02:58 PM, Paul Brook wrote:
> > On 03/11/2010 01:57 PM, Paul Brook wrote:
> > > +struct QEMUNotifier
> > >
> > > >   +{
> > > >   +    void (*notify)(QEMUNotifier *notifier);
> > > >   +};
> > >
> > > I suggest combining this with QEMUBH.
> >
> > I didn't understand this suggestion exactly, but I think it's related
> > that I didn't understand the advantage of making QEMUNotifier a struct.
>
> My point is that we already have a mechanism for providing event notification
> callbacks, specifically QEMUBH.  Why invent a new one?

QEMUBH seems seriously overengineered for this simple task.

Paolo