[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCHv5 04/11] virtio: notifier support + APIs for que
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCHv5 04/11] virtio: notifier support + APIs for queue fields |
Date: |
Wed, 17 Mar 2010 12:48:57 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Wed, Mar 17, 2010 at 09:44:05AM +0530, Amit Shah wrote:
> On (Tue) Mar 16 2010 [19:10:58], Michael S. Tsirkin wrote:
> >
> > diff --git a/hw/virtio.c b/hw/virtio.c
> > index 7c020a3..f54129f 100644
> > --- a/hw/virtio.c
> > +++ b/hw/virtio.c
> > @@ -73,6 +73,9 @@ struct VirtQueue
> > int inuse;
> > uint16_t vector;
> > void (*handle_output)(VirtIODevice *vdev, VirtQueue *vq);
> > + VirtIODevice *vdev;
> > + EventNotifier guest_notifier;
> > + EventNotifier host_notifier;
>
> Another thing that terribly confused me was this: in the vq struct you
> have guest_notifier and host_notifier of type EventNotifier and in the
> virtio binding structs you have guest_notifier and host_notifier which
> are function callbacks.
> Also, these vq->{guest_|host_}notifier assignments weren't easily found
> using grep because they're assigned by assigning a pointer value and
> initialising that pointer. Thanks to Juan for finding that for me :-)
>
> Amit
I've renamed them to set_xxx_notifier to avoid confusion.
> --
> http://log.amitshah.net/
- [Qemu-devel] [PATCHv5 00/11] vhost-net: upstream integration, Michael S. Tsirkin, 2010/03/16
- [Qemu-devel] [PATCHv5 01/11] tap: add interface to get device fd, Michael S. Tsirkin, 2010/03/16
- [Qemu-devel] [PATCHv5 03/11] notifier: event notifier implementation, Michael S. Tsirkin, 2010/03/16
- [Qemu-devel] [PATCHv5 04/11] virtio: notifier support + APIs for queue fields, Michael S. Tsirkin, 2010/03/16
- [Qemu-devel] [PATCHv5 05/11] virtio: add set_status callback, Michael S. Tsirkin, 2010/03/16
- [Qemu-devel] [PATCHv5 06/11] virtio: move typedef to qemu-common, Michael S. Tsirkin, 2010/03/16
- [Qemu-devel] [PATCHv5 07/11] virtio-pci: fill in notifier support, Michael S. Tsirkin, 2010/03/16
- [Qemu-devel] [PATCHv5 09/11] tap: add vhost/vhostfd options, Michael S. Tsirkin, 2010/03/16
- [Qemu-devel] [PATCHv5 10/11] tap: add API to retrieve vhost net header, Michael S. Tsirkin, 2010/03/16
- [Qemu-devel] [PATCHv5 11/11] virtio-net: vhost net support, Michael S. Tsirkin, 2010/03/16
- [Qemu-devel] [PATCHv5 08/11] vhost: vhost net support, Michael S. Tsirkin, 2010/03/16