[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/9] virtio-serial: save/load: Ensure we have hot-pl
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PATCH 5/9] virtio-serial: save/load: Ensure we have hot-plugged ports instantiated |
Date: |
Tue, 23 Mar 2010 20:00:15 +0530 |
If some ports that were hot-plugged on the source are not available on
the destination, fail migration instead of trying to deref a NULL
pointer.
Signed-off-by: Amit Shah <address@hidden>
Reported-by: Juan Quintela <address@hidden>
---
hw/virtio-serial-bus.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index bf7899c..e8eb5aa 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@ -447,6 +447,13 @@ static int virtio_serial_load(QEMUFile *f, void *opaque,
int version_id)
id = qemu_get_be32(f);
port = find_port_by_id(s, id);
+ if (!port) {
+ /*
+ * The requested port was hot-plugged on the source but we
+ * don't have it
+ */
+ return -EINVAL;
+ }
port->guest_connected = qemu_get_byte(f);
}
--
1.6.2.5
- [Qemu-devel] [PATCH 0/9] v2: Fixes, new way of discovering ports, Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 1/9] virtio-serial-bus: save/load: Ensure target has enough ports, Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 2/9] virtio-serial-bus: save/load: Ensure nr_ports on src and dest are same., Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 3/9] virtio-serial: Remove redundant check for 0-sized write request, Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 4/9] virtio-serial: Update copyright year to 2010, Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 5/9] virtio-serial: save/load: Ensure we have hot-plugged ports instantiated,
Amit Shah <=
- [Qemu-devel] [PATCH 6/9] virtio-serial-bus: Use control messages to notify guest of new ports, Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 7/9] virtio-serial-bus: Let the guest know of host connection changes after migration, Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 8/9] virtio-serial: Handle scatter-gather buffers for control messages, Amit Shah, 2010/03/23
- [Qemu-devel] [PATCH 9/9] virtio-serial: Handle scatter/gather input from the guest, Amit Shah, 2010/03/23
- [Qemu-devel] Re: [PATCH 9/9] virtio-serial: Handle scatter/gather input from the guest, Amit Shah, 2010/03/23
[Qemu-devel] Re: [PATCH 0/9] v2: Fixes, new way of discovering ports, Juan Quintela, 2010/03/23