[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v2 11/11] monitor: New commands netdev_add, netd
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] Re: [PATCH v2 11/11] monitor: New commands netdev_add, netdev_del |
Date: |
Thu, 25 Mar 2010 16:52:46 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> On Mon, 22 Mar 2010 10:48:53 +0100
> Markus Armbruster <address@hidden> wrote:
>
>> Monitor commands to go with -netdev.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> net.c | 57
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>> net.h | 2 +
>> qemu-monitor.hx | 30 ++++++++++++++++++++++++++++
>> 3 files changed, 88 insertions(+), 1 deletions(-)
>>
>> diff --git a/net.c b/net.c
>> index 1f3c39c..80e9025 100644
>> --- a/net.c
>> +++ b/net.c
>> @@ -1122,7 +1122,7 @@ int net_client_init(Monitor *mon, QemuOpts *opts, int
>> is_netdev)
>> }
>>
>> qerror_report(QERR_INVALID_PARAMETER_VALUE, "type",
>> - "a network backend type");
>> + "a network client type");
>> return -1;
>> }
>>
>> @@ -1186,6 +1186,61 @@ void net_host_device_remove(Monitor *mon, const QDict
>> *qdict)
>> qemu_del_vlan_client(vc);
>> }
>>
>> +/**
>> + * do_netdev_add(): Add a host network device
>> + *
>> + * Argument qdict contains
>> + * - "type": the device type, "tap", "user", ...
>> + * - "id": the device's ID (must be unique)
>
> Consecutive calls of this command in qmp with the same id succeeds, but
> I couldn't understand why.
Thinko. I'll respin.
> Other than that looks ok, although I'm not familiar with the device
> handling machinery in qemu.
v3's the charm, I hope.
Thanks!
[...]
- [Qemu-devel] [PATCH v2 00/11] monitor: New commands netdev_add, netdev_del, Markus Armbruster, 2010/03/22
- [Qemu-devel] [PATCH v2 01/11] error: Put error definitions back in alphabetical order, Markus Armbruster, 2010/03/22
- [Qemu-devel] [PATCH v2 04/11] error: New QERR_INVALID_PARAMETER_VALUE, Markus Armbruster, 2010/03/22
- [Qemu-devel] [PATCH v2 06/11] error: Drop extra messages after qemu_opts_set() and qemu_opts_parse(), Markus Armbruster, 2010/03/22
- [Qemu-devel] [PATCH v2 11/11] monitor: New commands netdev_add, netdev_del, Markus Armbruster, 2010/03/22
- [Qemu-devel] [PATCH v2 10/11] error: New QERR_DEVICE_IN_USE, Markus Armbruster, 2010/03/22
- [Qemu-devel] [PATCH v2 07/11] error: Use QERR_INVALID_PARAMETER_VALUE instead of QERR_INVALID_PARAMETER, Markus Armbruster, 2010/03/22
- [Qemu-devel] [PATCH v2 05/11] error: Convert qemu_opts_set() to QError, Markus Armbruster, 2010/03/22
- [Qemu-devel] [PATCH v2 08/11] error: Convert qemu_opts_validate() to QError, Markus Armbruster, 2010/03/22
- [Qemu-devel] [PATCH v2 03/11] error: Convert qemu_opts_create() to QError, Markus Armbruster, 2010/03/22
- [Qemu-devel] [PATCH v2 09/11] error: Convert net_client_init() to QError, Markus Armbruster, 2010/03/22
- [Qemu-devel] [PATCH v2 02/11] error: New QERR_DUPLICATE_ID, Markus Armbruster, 2010/03/22
- [Qemu-devel] Re: [PATCH v2 00/11] monitor: New commands netdev_add, netdev_del, Markus Armbruster, 2010/03/22