[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu: jaso-parser: Output the content of invali
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] qemu: jaso-parser: Output the content of invalid keyword |
Date: |
Sat, 27 Mar 2010 13:52:47 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Wed, Mar 24, 2010 at 11:12:05PM +0800, Amos Kong wrote:
>
> When input some invialid word 'unknowcmd' through QMP port, qemu outputs this
> error message:
> "parse error: invalid keyword `%s'"
> This patch makes qemu output the content of invalid keyword, like:
> "parse error: invalid keyword `unknowcmd'"
Thanks, applied.
> Signed-off-by: Amos Kong <address@hidden>
> ---
> json-parser.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/json-parser.c b/json-parser.c
> index 579928f..b55d763 100644
> --- a/json-parser.c
> +++ b/json-parser.c
> @@ -12,6 +12,7 @@
> */
>
> #include <stdbool.h>
> +#include <stdarg.h>
>
> #include "qemu-common.h"
> #include "qstring.h"
> @@ -93,7 +94,12 @@ static int token_is_escape(QObject *obj, const char *value)
> */
> static void parse_error(JSONParserContext *ctxt, QObject *token, const char
> *msg, ...)
> {
> - fprintf(stderr, "parse error: %s\n", msg);
> + va_list ap;
> + va_start(ap, msg);
> + fprintf(stderr, "parse error: ");
> + vfprintf(stderr, msg, ap);
> + fprintf(stderr, "\n");
> + va_end(ap);
> }
>
> /**
> --
> 1.6.3.3
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net