[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] x86: Fix MCA broadcast parameters for TCG case
From: |
Marcelo Tosatti |
Subject: |
[Qemu-devel] Re: [PATCH] x86: Fix MCA broadcast parameters for TCG case |
Date: |
Fri, 4 Feb 2011 11:58:56 -0200 |
User-agent: |
Mutt/1.5.20 (2009-08-17) |
On Wed, Feb 02, 2011 at 09:35:26PM +0100, Jan Kiszka wrote:
> On 2011-02-02 20:05, Blue Swirl wrote:
> > Signed-off-by: Blue Swirl <address@hidden>
> > ---
> > target-i386/helper.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/target-i386/helper.c b/target-i386/helper.c
> > index 1217452..4bbf9b1 100644
> > --- a/target-i386/helper.c
> > +++ b/target-i386/helper.c
> > @@ -1148,7 +1148,7 @@ void cpu_inject_x86_mce(CPUState *cenv, int
> > bank, uint64_t status,
> > continue;
> > }
> >
> > - qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0);
> > + qemu_inject_x86_mce(env, 1, 0xa000000000000000ULL, 0, 0,
> > 0);
> > }
> > }
> > }
>
> Let's fix this for real, the value is wrong anyway:
>
> ----------8<----------
>
> From: Jan Kiszka <address@hidden>
>
> When broadcasting MCEs, we need to set MCIP and RIPV in mcg_status like
> it is done for KVM. Use the symbolic constants at this chance.
>
> Signed-off-by: Jan Kiszka <address@hidden>
Applied to uq/master, thanks.