[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] For AIO return -ENOSPC on short write
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] For AIO return -ENOSPC on short write |
Date: |
Tue, 22 Feb 2011 16:11:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 |
Am 22.02.2011 16:02, schrieb Stefan Hajnoczi:
> On Tue, Feb 22, 2011 at 10:18 AM, <address@hidden> wrote:
>> + else if ((laiocb->type == QEMU_AIO_WRITE) && (ret >= 0) &&
>> + (ret < laiocb->nbytes))
>> + ret = -ENOSPC;
>
> Why is write special?
I think we need the change reads, too. However not to return ENOSPC, but
to return zeros instead (this is what the synchronous raw_read does, and
pwrite relies on it - once we make pwrite async, we'll need this).
> Why are we even allowing requests that extend beyond the end of the
> device? Is the LVM volume marked growable in the QEMU block layer?
Might well be a qcow2 on LVM case that Jes was debugging.
Kevin