[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] build: create shared-obj-y for tools/qemu-s
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] build: create shared-obj-y for tools/qemu-softmmu |
Date: |
Thu, 24 Feb 2011 11:12:51 +0000 |
On 24 February 2011 10:33, Juan Quintela <address@hidden> wrote:
> +# shared-obj-y has the object that are shared by qemu binary and tools
> +
> +shared-obj-y = qemu-error.o $(block-obj-y) $(qobject-obj-y) $(oslib-obj-y)
> +shared-obj-y += qemu-timer-common.o
I don't feel very strongly about this, but:
It seems a bit odd to have a shared-obj-y variable that isn't actually
a list of shared objects (ie .so files, DLLs). Maybe there's a better name?
-- PMM
- [Qemu-devel] [PATCH 0/2] build: make sharing of objects explicit, Juan Quintela, 2011/02/24
- [Qemu-devel] [PATCH 1/2] build: Create tools-obj-y variable, Juan Quintela, 2011/02/24
- [Qemu-devel] [PATCH 2/2] build: create shared-obj-y for tools/qemu-softmmu, Juan Quintela, 2011/02/24
- Re: [Qemu-devel] [PATCH 2/2] build: create shared-obj-y for tools/qemu-softmmu,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 2/2] build: create shared-obj-y for tools/qemu-softmmu, Markus Armbruster, 2011/02/24
- [Qemu-devel] Re: [PATCH 2/2] build: create shared-obj-y for tools/qemu-softmmu, Juan Quintela, 2011/02/24
- [Qemu-devel] Re: [PATCH 2/2] build: create shared-obj-y for tools/qemu-softmmu, Markus Armbruster, 2011/02/24
- [Qemu-devel] Re: [PATCH 2/2] build: create shared-obj-y for tools/qemu-softmmu, Paolo Bonzini, 2011/02/24
- [Qemu-devel] Re: [PATCH 2/2] build: create shared-obj-y for tools/qemu-softmmu, Juan Quintela, 2011/02/24