[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_tran
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction |
Date: |
Mon, 01 Apr 2013 09:52:59 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 04/01/2013 04:01 AM, Wenchao Xia wrote:
> Last operaton should be cancelled first.
s/operaton/operation/
[I don't care enough about US vs. UK to say whether canceled or
cancelled looks better]
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> blockdev.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index 75416fb..a24d10e 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -954,7 +954,7 @@ void qmp_transaction(BlockdevActionList *dev_list, Error
> **errp)
> dev_entry = dev_entry->next;
>
> states = g_malloc0(sizeof(BlkTransactionStates));
> - QSIMPLEQ_INSERT_TAIL(&snap_bdrv_states, states, entry);
> + QSIMPLEQ_INSERT_HEAD(&snap_bdrv_states, states, entry);
Is this a bug fix that for something that can be triggered by existing
use of the 'transaction' command even without the additions you made in
patches 1 and 2? If so, this probably ought to come first in the
series, and you probably ought to consider enhancing the testsuite to
show why it matters.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, (continued)
- Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, Wenchao Xia, 2013/04/03
- Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, Paolo Bonzini, 2013/04/03
- Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, Wenchao Xia, 2013/04/03
- Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, Paolo Bonzini, 2013/04/03
- Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, Kevin Wolf, 2013/04/03
- Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, Wenchao Xia, 2013/04/03
Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable, Stefan Hajnoczi, 2013/04/17
[Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction, Wenchao Xia, 2013/04/01