[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device |
Date: |
Wed, 3 Apr 2013 13:38:46 +0300 |
On Wed, Apr 03, 2013 at 12:34:24PM +0200, Paolo Bonzini wrote:
> Il 03/04/2013 12:33, Michael S. Tsirkin ha scritto:
> > > Because someone wasn't looking. :) The hw/ reorganization patches I've
> > > posted fix that.
> >
> > Still not sure how to merge this, if it goes in through my tree
> > and that's the only comment, I'll just fix it silently ...
>
> Indeed. In fact, considering my hw/ reorganization patches will be
> committed soon, please put it in hw/pci (matching hw/isa/pc-testdev.c).
Paolo, hw/pci is pci core, I haven't looked at your reorg patches,
but please do not move devices there.
Sorting devices by connection is also wrong I think, by function
would be better.
> Another comment is that you should add a description in docs/specs.
>
> Paolo
pc-test has none ... I'll see what I can do.
--
MST
- [Qemu-devel] [PATCH 2/4] kvm: support any size for pio eventfd, (continued)
- [Qemu-devel] [PATCH 2/4] kvm: support any size for pio eventfd, Michael S. Tsirkin, 2013/04/03
- [Qemu-devel] [PATCH 3/4] kvm: support non datamatch ioeventfd, Michael S. Tsirkin, 2013/04/03
- [Qemu-devel] [PATCH 4/4] pci: add pci test device, Michael S. Tsirkin, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Paolo Bonzini, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Michael S. Tsirkin, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Paolo Bonzini, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Michael S. Tsirkin, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Paolo Bonzini, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Michael S. Tsirkin, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Paolo Bonzini, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Paolo Bonzini, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Michael S. Tsirkin, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Paolo Bonzini, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Michael S. Tsirkin, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Paolo Bonzini, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Michael S. Tsirkin, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Paolo Bonzini, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Michael S. Tsirkin, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Paolo Bonzini, 2013/04/03
- Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device, Michael S. Tsirkin, 2013/04/03