[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/nand.c: Fix nand erase operation
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] hw/nand.c: Fix nand erase operation |
Date: |
Fri, 5 Apr 2013 17:19:10 +0100 |
On 3 April 2013 06:33, Peter Crosthwaite <address@hidden> wrote:
> From: Wendy Liang <address@hidden>
>
> Usually, nand erase operation has only 2 or 3 address cycles.
> We need to mask s->addr to zero unset stale high-order bytes in the nand
> address
> before using it as the erase address.
>
> This fixes the NAND erase operation in Linux.
>
> [PC: Generalised to work for any number of address cycles rather than just 3]
>
> Signed-off-by: Wendy Liang <address@hidden>
> Signed-off-by: Peter Crosthwaite <address@hidden>
I kind of feel like in the long term this is making this code even
more confusing, but at least it fixes the bug and doesn't mess
anything else up.
Applied to arm-devs.next.
thanks
-- PMM