[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 11/11] hw/versatile_pci: Drop unnecessary vpb_pci
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH v4 11/11] hw/versatile_pci: Drop unnecessary vpb_pci_config_addr() |
Date: |
Sat, 6 Apr 2013 16:44:36 +0100 |
Drop the vpb_pci_config_addr() function -- it is unnecessary since
the size of the memory regions means the hwaddr is always within
the 24 bit size. (This function was probably a leftover from when
read/write functions were called with absolute addresses rather
than relative ones.)
Signed-off-by: Peter Maydell <address@hidden>
Acked-by: Paul Brook <address@hidden>
---
hw/versatile_pci.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/hw/versatile_pci.c b/hw/versatile_pci.c
index e99f35f..540daf7 100644
--- a/hw/versatile_pci.c
+++ b/hw/versatile_pci.c
@@ -214,11 +214,6 @@ static const MemoryRegionOps pci_vpb_reg_ops = {
},
};
-static inline uint32_t vpb_pci_config_addr(hwaddr addr)
-{
- return addr & 0xffffff;
-}
-
static void pci_vpb_config_write(void *opaque, hwaddr addr,
uint64_t val, unsigned size)
{
@@ -234,7 +229,7 @@ static void pci_vpb_config_write(void *opaque, hwaddr addr,
}
}
}
- pci_data_write(&s->pci_bus, vpb_pci_config_addr(addr), val, size);
+ pci_data_write(&s->pci_bus, addr, val, size);
}
static uint64_t pci_vpb_config_read(void *opaque, hwaddr addr,
@@ -242,7 +237,7 @@ static uint64_t pci_vpb_config_read(void *opaque, hwaddr
addr,
{
PCIVPBState *s = opaque;
uint32_t val;
- val = pci_data_read(&s->pci_bus, vpb_pci_config_addr(addr), size);
+ val = pci_data_read(&s->pci_bus, addr, size);
return val;
}
--
1.7.9.5
- [Qemu-devel] [PATCH v4 00/11] Fix versatile_pci, Peter Maydell, 2013/04/06
- [Qemu-devel] [PATCH v4 08/11] versatile_pci: Implement the PCI controller's control registers, Peter Maydell, 2013/04/06
- [Qemu-devel] [PATCH v4 10/11] versatile_pci: Expose PCI memory space to system, Peter Maydell, 2013/04/06
- [Qemu-devel] [PATCH v4 06/11] versatile_pci: Put the host bridge PCI device at slot 29, Peter Maydell, 2013/04/06
- [Qemu-devel] [PATCH v4 03/11] versatile_pci: Update to realize and instance init functions, Peter Maydell, 2013/04/06
- [Qemu-devel] [PATCH v4 01/11] versatile_pci: Fix hardcoded tabs, Peter Maydell, 2013/04/06
- [Qemu-devel] [PATCH v4 11/11] hw/versatile_pci: Drop unnecessary vpb_pci_config_addr(),
Peter Maydell <=
- [Qemu-devel] [PATCH v4 02/11] versatile_pci: Expose PCI I/O region on Versatile PB, Peter Maydell, 2013/04/06
- [Qemu-devel] [PATCH v4 07/11] versatile_pci: Implement the correct PCI IRQ mapping, Peter Maydell, 2013/04/06
- [Qemu-devel] [PATCH v4 09/11] arm/realview: Fix mapping of PCI regions, Peter Maydell, 2013/04/06
- [Qemu-devel] [PATCH v4 05/11] versatile_pci: Use separate PCI I/O space rather than system I/O space, Peter Maydell, 2013/04/06
- [Qemu-devel] [PATCH v4 04/11] versatile_pci: Change to subclassing TYPE_PCI_HOST_BRIDGE, Peter Maydell, 2013/04/06
- Re: [Qemu-devel] [PATCH v4 00/11] Fix versatile_pci, Rob Landley, 2013/04/08