[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building aft
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge |
|
Date: |
Tue, 09 Apr 2013 13:30:16 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> Il 09/04/2013 11:30, KONRAD Frédéric ha scritto:
>>>>
>>>> #include "hw/virtio/virtio.h"
>>>> +#include "hw/virtio/virtio-9p.h"
>> [..]
>>>> #include "virtio-9p.h"
>> Is that normal?
>>
>> We have two virtio-9p.h:
>> ./hw/9pfs/virtio-9p.h
>> ./include/hw/virtio/virtio-9p.h
>>
>> which can be confusing.
>
> Yes, the first one is only included with a local path. Though I think
> this is what confused my scripts.
It'll confuse maintenance programmers, too. Rename one of them? For
what it's worth, the second was named virtio-9p-device.h until you
renamed & moved it.
Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge, Anthony Liguori, 2013/04/15