[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] migration: drop is_write complications
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] migration: drop is_write complications |
Date: |
Tue, 09 Apr 2013 13:55:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 09/04/2013 13:42, Juan Quintela ha scritto:
>> > @@ -556,11 +557,7 @@ static void qemu_fill_buffer(QEMUFile *f)
>> > int len;
>> > int pending;
>> >
>> > - if (!f->ops->get_buffer)
>> > - return;
> Why are we removing this test? this has nothing to do with the is_write
> removal?
This test assumes that it makes sense to call qemu_get_byte on a
write-opened QEMUFile. This is not true anymore after this patch.
After eliminating is_write, the right thing to do is abort.
Paolo
> And yes, having a better way of knowing that the operations are there
> looks like a good idea, but that is independent of this series.
[Qemu-devel] [PATCH 2/4] migration: use a single I/O operation when writev_buffer is not defined, Paolo Bonzini, 2013/04/08
[Qemu-devel] [PATCH 4/4] migration: simplify writev vs. non-writev logic, Paolo Bonzini, 2013/04/08