[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] hw/sm501: Use correct setter for sysbus-
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] hw/sm501: Use correct setter for sysbus-ohci dma-address property |
|
Date: |
Tue, 16 Apr 2013 15:49:52 +0100 |
On 16 April 2013 15:47, Andreas Färber <address@hidden> wrote:
> Am 09.04.2013 13:27, schrieb Peter Maydell:
>> The sysbus-ohci dma-address property is declared as a HEX64
>> property, not a TADDR, so use the correct setter for it.
>
> Actually, it's declared as
> DEFINE_PROP_DMAADDR("dma-offset", OHCISysBusState, dma_offset, 3),
> which is in turn defined as DEFINE_PROP_HEX64 in include/hw/qdev-dma.h.
Yes, I abbreviated a bit.
> You could also remove the include now, right?
In theory, but given patch 2 it's a bit moot :-)
> Either way,
>
> Acked-by: Andreas Färber <address@hidden>
Thanks.
-- PMM