[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic |
Date: |
Thu, 18 Apr 2013 16:06:11 +0300 |
On Thu, Apr 18, 2013 at 09:59:52AM -0400, Michael R. Hines wrote:
> On 04/18/2013 03:58 AM, Michael S. Tsirkin wrote:
> >The following comment applies to all of this code:
> >
> >On Wed, Apr 17, 2013 at 07:07:17PM -0400, address@hidden wrote:
> >>diff --git a/migration-rdma.c b/migration-rdma.c
> >>new file mode 100644
> >>index 0000000..1dff06f
> >>--- /dev/null
> >>+++ b/migration-rdma.c
> >>@@ -0,0 +1,2667 @@
> >>+/*
> >>+ * Copyright (C) 2013 Michael R. Hines <address@hidden>
> >>+ * Copyright (C) 2010 Jiuxing Liu <address@hidden>
> >By the way do you both really hold copyrights on this code?
> >It's not assigned to IBM?
> >If the later it should say:
> > Copyright IBM
> > Author: Michael R. Hines
> >Or some such.
>
> Acknowledged.
>
> >>+ *
> >>+ * RDMA protocol and interfaces
> >>+ *
> >>+ * This program is free software; you can redistribute it and/or modify
> >>+ * it under the terms of the GNU General Public License as published by
> >>+ * the Free Software Foundation; under version 2 of the License.
> >
> >We prefer 2 or later for new code.
>
> Doesn't it say version 2 already?
version 2 != 'version 2 or later'. See COPYING at the top level in qemu.
> >I'm guessing you need approval from Jiuxing Liu for this,
> >pls make him ack license change.
>
> He approves. He doesn't work for IBM anymore.
Does he approve version 2 or version 2 or later?
- Re: [Qemu-devel] [PULL v4 11/11] rdma: add documentation, (continued)
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael S. Tsirkin, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael R. Hines, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael R. Hines, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael S. Tsirkin, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael R. Hines, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Michael S. Tsirkin, 2013/04/18
- Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Anthony Liguori, 2013/04/18
- [Qemu-devel] licensing of IBM contributions to QEMU (was Re: [PULL v4 08/11] rdma: core logic), Paolo Bonzini, 2013/04/18
- Re: [Qemu-devel] licensing of IBM contributions to QEMU (was Re: [PULL v4 08/11] rdma: core logic), Michael R. Hines, 2013/04/18
- Re: [Qemu-devel] licensing of IBM contributions to QEMU (was Re: [PULL v4 08/11] rdma: core logic), Anthony Liguori, 2013/04/18
Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic, Eric Blake, 2013/04/18