[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.5 v2 06/15] xilinx_spips: Trash LQ page ca
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH for-1.5 v2 06/15] xilinx_spips: Trash LQ page cache on mode change |
Date: |
Fri, 19 Apr 2013 11:23:22 +0100 |
On 19 April 2013 03:06, <address@hidden> wrote:
> From: Peter Crosthwaite <address@hidden>
>
> Invalidate the LQSPI cached page when transitioning into LQSPI mode.
> Otherwise there is a possibility that the controller will return stale
> data to the guest when transitioning back to LQ_MODE after a page
> program.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
> changed from v1:
> Re-implemented using separate SPI/QSPI write handlers.
>
> hw/ssi/xilinx_spips.c | 26 +++++++++++++++++++++++++-
> 1 files changed, 25 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
> index e351cb2..6d38111 100644
> --- a/hw/ssi/xilinx_spips.c
> +++ b/hw/ssi/xilinx_spips.c
> @@ -165,6 +165,8 @@ typedef struct {
> typedef struct XilinxSPIPSClass {
> SysBusDeviceClass parent_class;
>
> + const MemoryRegionOps *reg_ops;
> +
> uint32_t rx_fifo_size;
> uint32_t tx_fifo_size;
> } XilinxSPIPSClass;
> @@ -446,6 +448,7 @@ static void xilinx_spips_write(void *opaque, hwaddr addr,
> case R_TXD3:
> tx_data_bytes(s, (uint32_t)value, 3);
> goto no_reg_update;
> + break;
Why insert code after a goto?
> }
> s->regs[addr] = (s->regs[addr] & ~mask) | (value & mask);
> no_reg_update:
-- PMM
- [Qemu-devel] [PATCH for-1.5 v2 00/15] Xilinx SPIPS fixes round 2, peter . crosthwaite, 2013/04/18
- [Qemu-devel] [PATCH for-1.5 v2 01/15] xilinx_spips: seperate SPI and QSPI as two classes, peter . crosthwaite, 2013/04/18
- [Qemu-devel] [PATCH for-1.5 v2 02/15] xilinx_spips: Make interrupts clear on read, peter . crosthwaite, 2013/04/18
- [Qemu-devel] [PATCH for-1.5 v2 03/15] xilinx_spips: Inhibit interrupts in LQSPI mode, peter . crosthwaite, 2013/04/18
- [Qemu-devel] [PATCH for-1.5 v2 04/15] xilinx_spips: Add verbose LQSPI debug output, peter . crosthwaite, 2013/04/18
- [Qemu-devel] [PATCH for-1.5 v2 05/15] xilinx_spips: Fix QSPI FIFO size, peter . crosthwaite, 2013/04/18
- [Qemu-devel] [PATCH for-1.5 v2 06/15] xilinx_spips: Trash LQ page cache on mode change, peter . crosthwaite, 2013/04/18
- Re: [Qemu-devel] [PATCH for-1.5 v2 06/15] xilinx_spips: Trash LQ page cache on mode change,
Peter Maydell <=
- [Qemu-devel] [PATCH for-1.5 v2 07/15] xilinx_spips: Add automatic start support, peter . crosthwaite, 2013/04/18
- [Qemu-devel] [PATCH for-1.5 v2 08/15] xilinx_spips: Implement automatic CS, peter . crosthwaite, 2013/04/18
- [Qemu-devel] [PATCH for-1.5 v2 09/15] xilinx_spips: lqspi: Dont touch config register, peter . crosthwaite, 2013/04/18
- [Qemu-devel] [PATCH for-1.5 v2 10/15] xilinx_spips: Fix CTRL register RW bits, peter . crosthwaite, 2013/04/18
- [Qemu-devel] [PATCH for-1.5 v2 11/15] xilinx_spips: Fix striping behaviour, peter . crosthwaite, 2013/04/18
- [Qemu-devel] [PATCH for-1.5 v2 12/15] xilinx_spips: Debug msgs for Snoop state, peter . crosthwaite, 2013/04/18
- [Qemu-devel] [PATCH for-1.5 v2 13/15] xilinx_spips: Multiple debug verbosity levels, peter . crosthwaite, 2013/04/18
- [Qemu-devel] [PATCH for-1.5 v2 14/15] xilinx_spips: lqspi: Push more data to tx-fifo, peter . crosthwaite, 2013/04/18
- [Qemu-devel] [PATCH for-1.5 v2 15/15] xilinx_spips: lqspi: Fix byte/misaligned access, peter . crosthwaite, 2013/04/18