[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 17/19] tcg-arm: Use movi32 + blx for calls on
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v5 17/19] tcg-arm: Use movi32 + blx for calls on v7 |
Date: |
Mon, 22 Apr 2013 11:55:31 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Mar 31, 2013 at 03:35:03PM -0700, Richard Henderson wrote:
> Work better with branch predition when we have movw+movt,
> as the size of the code is the same. Perhaps re-evaluate
> when we have a proper constant pool.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> tcg/arm/tcg-target.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
> index 35598a8..ff6dc90 100644
> --- a/tcg/arm/tcg-target.c
> +++ b/tcg/arm/tcg-target.c
> @@ -1019,6 +1019,9 @@ static inline void tcg_out_call(TCGContext *s, uint32_t
> addr)
> } else {
> tcg_out_bl(s, COND_AL, val);
> }
> + } else if (use_armv7_instructions) {
> + tcg_out_movi32(s, COND_AL, TCG_REG_TMP, addr);
> + tcg_out_blx(s, COND_AL, TCG_REG_TMP);
> } else {
> tcg_out_dat_imm(s, COND_AL, ARITH_ADD, TCG_REG_R14, TCG_REG_PC, 4);
> tcg_out_ld32_12(s, COND_AL, TCG_REG_PC, TCG_REG_PC, -4);
Reviewed-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v5 17/19] tcg-arm: Use movi32 + blx for calls on v7,
Aurelien Jarno <=