[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all |
|
Date: |
Tue, 23 Apr 2013 18:54:47 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2013-04-23 18:43, Paolo Bonzini wrote:
> Il 23/04/2013 18:13, Paolo Bonzini ha scritto:
>> Il 23/04/2013 10:47, Jan Kiszka ha scritto:
>>>>> if (val & LSI_ISTAT0_SRST) {
>>>>> - lsi_soft_reset(s);
>>>>> + qdev_reset_all(&s->dev.qdev);
>>> What should ensure that all device resets are performed before the host
>>> reset? I'm asking as we just ran into the assert(!s->current) over
>>> 1.3.1. Or is there some patch from a later version missing (not seeing
>>> anything suspicious for lsi at least)?
>>
>> qdev should, but it looks like it uses pre-order instead of post-order.
>
> Something like this series (based on 1.3.0), totally untested.
Forwarded to the folks who managed to trigger this. Will let you know.
Many thanks!
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux