[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/12] covert savevm, loadvm and delvm into q
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/12] covert savevm, loadvm and delvm into qapi |
Date: |
Wed, 24 Apr 2013 10:15:54 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/24/2013 09:31 AM, Pavel Hrdina wrote:
> I'm sending patches for all commands in one patch series because the
> savevm command depends on delvm command.
I debated whether to call this out, but here goes:
I pointed out s/covert/convert/ on the subject line of v1; that can't
bode too well if the v2 still has the same problem, even if the problem
does not affect anything that gets committed into git.
Here's hoping the rest of the series is better...
>
> This patch series introduces new design of these commands:
At this point, we've missed soft freeze. Is this something we are still
trying to get into 1.5, or is it okay to slip it to 1.6 where we can
feel more comfortable about having a solid review in place? Ultimately,
it's the maintainer's call, but I'm personally leaning towards deferring
- libvirt has survived with HMP savevm long enough that another qemu
release without QMP savevm won't be the end of the world. I'm also
hoping that the final product is clean enough that a distro could feel
comfortable with the idea of rebasing to 1.5 while still backporting the
QMP commands that go into 1.6.
>
> changes from v1:
> - patch for updating bdrv_snapshot_goto and bdrv_snapshot_list is split
> into two patches
> - fixes typos and grammar
> - vm-snapshot-delete and vm-snapshot-load now returns an error also if
> snapshot for delete or load not exists
> - all error messages starts with uppercase and are without trailing dot
> - updated error messages recording to comments
...at least the summary makes it sound like you made a good effort. It
might also help to provide a bit of context on how we are planning on
tackling any merge conflicts regarding the algorithm for snapshot
lookup, and whether there are any rebase dependencies between your
series and Wenchao's.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 09/12] block: update error reporting for bdrv_snapshot_create() and related functions, (continued)
- [Qemu-devel] [PATCH v2 09/12] block: update error reporting for bdrv_snapshot_create() and related functions, Pavel Hrdina, 2013/04/24
- [Qemu-devel] [PATCH v2 05/12] block: update error reporting for bdrv_snapshot_goto() and related functions, Pavel Hrdina, 2013/04/24
- [Qemu-devel] [PATCH v2 11/12] qapi: Convert savevm, Pavel Hrdina, 2013/04/24
- [Qemu-devel] [PATCH v2 12/12] savevm: remove backward compatibility from bdrv_snapshot_find(), Pavel Hrdina, 2013/04/24
- [Qemu-devel] [PATCH v2 06/12] block: update error reporting for bdrv_snapshot_list() and related functions, Pavel Hrdina, 2013/04/24
- [Qemu-devel] [PATCH v2 07/12] savevm: update error reporting for qemu_loadvm_state(), Pavel Hrdina, 2013/04/24
- [Qemu-devel] [PATCH v2 02/12] block: update error reporting for bdrv_snapshot_delete() and related functions, Pavel Hrdina, 2013/04/24
- Re: [Qemu-devel] [PATCH v2 00/12] covert savevm, loadvm and delvm into qapi,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v2 00/12] covert savevm, loadvm and delvm into qapi, Stefan Hajnoczi, 2013/04/25