Re: [Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension

[Lei Li]

On 04/24/2013 07:44 PM, Gerd Hoffmann wrote:
>    Hi,
>
> > +        case VNC_ENCODING_LED_STATE:
> > +            vs->features |= VNC_FEATURE_LED_STATE_MASK;
> > +            break;
> I think it with the client supporting the led state extension it is
> probably a good idea to turn off the lock state sync logic in qemu's vnc
> server, i.e. add a "!(vs->features & VNC_FEATURE_LED_STATE_MASK)" check
> next to the lock_key_sync checks in do_key_event().
>
> cheers,
>    Gerd

Hi Gerd,

Yes, I think it's a good idea.
Thanks!

>


--
Lei