[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command |
Date: |
Mon, 29 Apr 2013 09:51:47 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/29/2013 03:27 AM, Paolo Bonzini wrote:
> Il 29/04/2013 09:21, Stefan Hajnoczi ha scritto:
>>> I'd really love to see us change 'BlockJobInfo' to use an enum for
>>> 'type', instead of its open-coded 'str'. Likewise, the block-job
>>> related events in QMP/qmp-events.txt should be updated to refer to the
>>> enum instead of also being open-coded 'str'.
>>
>> Since the block job QMP API has been in released I'm not sure changing
>> this is worthwhile. QEMU and libvirt would have to maintain
>> compatibility so the code will just be duplicated.
>
> I don't think this would change the actual data on the wire. However,
> it would let libvirt know the supported block job types by introspecting
> the enum.
Until we have introspection, the point is moot. When we have
introspection, libvirt would much rather see an enum than a 'str'. I
see absolutely no back-compat problem in changing the code to be
type-safe prior to the point that introspection is added.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH 0/3] block: block-backup live backup command, Eric Blake, 2013/04/23
Re: [Qemu-devel] [PATCH 0/3] block: block-backup live backup command, Wenchao Xia, 2013/04/27