[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_du
|
From: |
Luiz Capitulino |
|
Subject: |
Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump() |
|
Date: |
Mon, 29 Apr 2013 15:05:41 -0400 |
On Fri, 26 Apr 2013 16:46:57 +0200
Stefan Hajnoczi <address@hidden> wrote:
> On Fri, Apr 26, 2013 at 05:31:15PM +0800, Wenchao Xia wrote:
> > @@ -2586,10 +2585,12 @@ void do_info_snapshots(Monitor *mon, const QDict
> > *qdict)
> > }
> >
> > if (total > 0) {
> > - monitor_printf(mon, "%s\n", bdrv_snapshot_dump(buf, sizeof(buf),
> > NULL));
> > + bdrv_snapshot_dump(NULL);
> > + monitor_printf(mon, "\n");
>
> Luiz: any issue with mixing monitor_printf(mon) and
> monitor_vprintf(cur_mon) calls? I guess there was a reason for
> explicitly passing mon instead of relying on cur_mon.
where are they being mixed?
- Re: [Qemu-devel] [PATCH 3/7] block: move snapshot code in block.c to block/snapshot.c, (continued)