[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.5 v3 08/15] xilinx_spips: Implement automa
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH for-1.5 v3 08/15] xilinx_spips: Implement automatic CS |
Date: |
Tue, 30 Apr 2013 10:29:28 +1000 |
Hi Peter,
On Mon, Apr 29, 2013 at 10:14 PM, Peter Maydell
<address@hidden> wrote:
> On 22 April 2013 06:16, <address@hidden> wrote:
>> From: Peter Crosthwaite <address@hidden>
>>
>> Implement the automatic CS control feature. If the MANUAL_CS bit is
>> cleared then the chip select stay de-asserted as long as the tx FIFO
>> is empty.
>>
>> Signed-off-by: Peter Crosthwaite <address@hidden>
>> Reviewed-by: Peter Maydell <address@hidden>
>
> Doesn't compile:
>
> hw/ssi/xilinx_spips.c: In function ‘xilinx_spips_update_cs_lines’:
> hw/ssi/xilinx_spips.c:215:17: error: implicit declaration of function
> ‘DB_PRINT_L’ [-Werror=implicit-function-declaration]
> hw/ssi/xilinx_spips.c:215:17: error: nested extern declaration of
> ‘DB_PRINT_L’ [-Werror=nested-externs]
> cc1: all warnings being treated as errors
>
> (you don't introduce that macro until later).
>
Nice catch. Thanks. I have now added individual patch compile testing
to my format-patch wrapper script to catch these. Will fix.
Regards,
Peter
> -- PMM
>
- [Qemu-devel] [PATCH for-1.5 v3 01/15] xilinx_spips: seperate SPI and QSPI as two classes, (continued)
- [Qemu-devel] [PATCH for-1.5 v3 01/15] xilinx_spips: seperate SPI and QSPI as two classes, peter . crosthwaite, 2013/04/22
- [Qemu-devel] [PATCH for-1.5 v3 02/15] xilinx_spips: Make interrupts clear on read, peter . crosthwaite, 2013/04/22
- [Qemu-devel] [PATCH for-1.5 v3 03/15] xilinx_spips: Inhibit interrupts in LQSPI mode, peter . crosthwaite, 2013/04/22
- [Qemu-devel] [PATCH for-1.5 v3 04/15] xilinx_spips: Add verbose LQSPI debug output, peter . crosthwaite, 2013/04/22
- [Qemu-devel] [PATCH for-1.5 v3 05/15] xilinx_spips: Fix QSPI FIFO size, peter . crosthwaite, 2013/04/22
- [Qemu-devel] [PATCH for-1.5 v3 06/15] xilinx_spips: Trash LQ page cache on mode change, peter . crosthwaite, 2013/04/22
- [Qemu-devel] [PATCH for-1.5 v3 07/15] xilinx_spips: Add automatic start support, peter . crosthwaite, 2013/04/22
- [Qemu-devel] [PATCH for-1.5 v3 08/15] xilinx_spips: Implement automatic CS, peter . crosthwaite, 2013/04/22
- [Qemu-devel] [PATCH for-1.5 v3 09/15] xilinx_spips: lqspi: Dont touch config register, peter . crosthwaite, 2013/04/22
- [Qemu-devel] [PATCH for-1.5 v3 11/15] xilinx_spips: Fix striping behaviour, peter . crosthwaite, 2013/04/22
- [Qemu-devel] [PATCH for-1.5 v3 12/15] xilinx_spips: Debug msgs for Snoop state, peter . crosthwaite, 2013/04/22
- [Qemu-devel] [PATCH for-1.5 v3 13/15] xilinx_spips: Multiple debug verbosity levels, peter . crosthwaite, 2013/04/22
- [Qemu-devel] [PATCH for-1.5 v3 14/15] xilinx_spips: lqspi: Push more data to tx-fifo, peter . crosthwaite, 2013/04/22
- [Qemu-devel] [PATCH for-1.5 v3 15/15] xilinx_spips: lqspi: Fix byte/misaligned access, peter . crosthwaite, 2013/04/22
- [Qemu-devel] [PATCH for-1.5 v3 10/15] xilinx_spips: Fix CTRL register RW bits, peter . crosthwaite, 2013/04/22
- Re: [Qemu-devel] [PATCH for-1.5 v3 00/15] Xilinx SPIPS fixes round 2, Edgar E. Iglesias, 2013/04/30