[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-arm: cpu: set default cpu_model via QEMU
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-arm: cpu: set default cpu_model via QEMUMachine.cpu_model |
|
Date: |
Tue, 30 Apr 2013 12:06:31 -0300 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Apr 30, 2013 at 03:55:24PM +0100, Peter Maydell wrote:
> On 30 April 2013 15:48, Igor Mammedov <address@hidden> wrote:
> > Signed-off-by: Igor Mammedov <address@hidden>
> > ---
> > compile tested only ...
> >
> > ---
> > hw/arm/realview.c | 16 ++++------------
> > hw/arm/versatilepb.c | 5 ++---
>
> Anything that's only touching these two boards is clearly
> not considering the whole situation -- more boards than
> just these two have a board specific default CPU.
You're right. In other words: QEMUMachineInitArgs.cpu_model may be an
easy-to-find redundant variable that should be eventually replaced by
QEMUMachine.cpu_model, but we probably have dozens of local variables
used for the same thing in other code.
--
Eduardo
- Re: [Qemu-devel] [PATCH 1/5] add hot_add_cpu hook to QEMUMachine, (continued)
- [Qemu-devel] [PATCH 2/5] QMP: add cpu-add command, Igor Mammedov, 2013/04/30
- [Qemu-devel] [PATCH 3/5] add cpu_model to QEMUMachine, Igor Mammedov, 2013/04/30
- Re: [Qemu-devel] [PATCH 3/5] add cpu_model to QEMUMachine, Peter Maydell, 2013/04/30
- Re: [Qemu-devel] [PATCH 3/5] add cpu_model to QEMUMachine, Igor Mammedov, 2013/04/30
- Re: [Qemu-devel] [PATCH 3/5] add cpu_model to QEMUMachine, Peter Maydell, 2013/04/30
[Qemu-devel] [PATCH 5/5] target-i386: implement machine->hot_add_cpu hook, Igor Mammedov, 2013/04/30
[Qemu-devel] [PATCH 4/5] target-i386: get default cpu_model from QEMUMachine, Igor Mammedov, 2013/04/30