[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] add hot_add_cpu hook to QEMUMachine
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] add hot_add_cpu hook to QEMUMachine |
Date: |
Tue, 30 Apr 2013 17:48:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
Am 30.04.2013 15:41, schrieb Igor Mammedov:
> Hook should be set by target that implements
> CPU hot-add via cpu-add QMP command.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> include/hw/boards.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Thanks, applied to qom-cpu (using a typedef and regrouping it):
https://github.com/afaerber/qemu-cpu/commits/qom-cpu
This is obviously tied to how the QMP command looks like, but I don't
see much room to rearchitect that today - if machines can't support this
simplified interface due to complex SoC setups they simply don't
implement this hook and cpu-add should fail.
Andreas
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index 425bdc7..75cd127 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -43,6 +43,7 @@ typedef struct QEMUMachine {
> GlobalProperty *compat_props;
> struct QEMUMachine *next;
> const char *hw_version;
> + void (*hot_add_cpu)(const int64_t id, Error **errp);
> } QEMUMachine;
>
> int qemu_register_machine(QEMUMachine *m);
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg