[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] block: distinguish id and name in bdrv_find
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] block: distinguish id and name in bdrv_find_snapshot() |
Date: |
Tue, 30 Apr 2013 11:52:57 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/26/2013 09:34 PM, Wenchao Xia wrote:
>>> to find the snapshot, instead once, so matching sequence may change
>>> if there are unwisely chosen, mixed id and names.
>>> 2) In do_savevm(), same with del_existing_snapshot(), when it tries to
>>> find the snapshot to overwrite, matching sequence may change for same
>>> reason.
>>> 3) In load_vmstate(), first when it tries to find the snapshot to be
>>> loaded,
>>> sequence may change for the same reason of above. Later in
>>> validation, the
>>> logic is changed to be more strict to require both id and name matching.
>>> 4) In do_info_snapshot(), in validation, the logic is changed to be more
>>> strict to require both id and name matching.
>>
>> It's easy to avoid changing semantics: keep the old name or id behavior
>> around. Use the new name-and-id behavior for #3 and #4.
> You mean adding a new function, instead of change
> bdrv_find_snapshot()?
That's certainly an option. Although after Pavel's proposed series for
adding QMP counterpart to savevm, there are no longer any uses of the
old semantics.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/7] qapi and snapshot code clean up in block layer, Wenchao Xia, 2013/04/26
- [Qemu-devel] [PATCH 1/7] block: drop bs_snapshots global variable, Wenchao Xia, 2013/04/26
- [Qemu-devel] [PATCH 2/7] block: move bdrv_snapshot_find() to block/snapshot.c, Wenchao Xia, 2013/04/26
- [Qemu-devel] [PATCH 3/7] block: move snapshot code in block.c to block/snapshot.c, Wenchao Xia, 2013/04/26
- [Qemu-devel] [PATCH 4/7] block: distinguish id and name in bdrv_find_snapshot(), Wenchao Xia, 2013/04/26
- Re: [Qemu-devel] [PATCH 4/7] block: distinguish id and name in bdrv_find_snapshot(), Eric Blake, 2013/04/30
- [Qemu-devel] [PATCH 5/7] block: move collect_snapshots() and collect_image_info() to block/qapi.c, Wenchao Xia, 2013/04/26
- [Qemu-devel] [PATCH 6/7] block: move qmp and info dump related code to block/qapi.c, Wenchao Xia, 2013/04/26
- [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(), Wenchao Xia, 2013/04/26