Re: [Qemu-devel] [PATCH] vmxnet3: fix NICState cleanup

[Dmitry Fleytman]

Hi Stefan,

Thanks for fixing this.

Dmitry.

Sent from my iPad

On Jun 4, 2013, at 2:47 PM, Stefan Hajnoczi <address@hidden> wrote:

> Use qemu_del_nic() instead of qemu_del_net_client() to correctly free
> the entire NICState.
> 
> Reported-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> hw/net/vmxnet3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index 5f483e7..4c575e5 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -1892,7 +1892,7 @@ static void vmxnet3_net_uninit(VMXNET3State *s)
>     vmxnet_tx_pkt_reset(s->tx_pkt);
>     vmxnet_tx_pkt_uninit(s->tx_pkt);
>     vmxnet_rx_pkt_uninit(s->rx_pkt);
> -    qemu_del_net_client(qemu_get_queue(s->nic));
> +    qemu_del_nic(s->nic);
> }
> 
> static void vmxnet3_net_init(VMXNET3State *s)
> -- 
> 1.8.1.4
>