[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/5] use qemu_pipe_non_block
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 2/5] use qemu_pipe_non_block |
Date: |
Tue, 4 Jun 2013 21:50:41 +0100 |
On 4 June 2013 21:23, Alon Levy <address@hidden> wrote:
> --- a/hw/display/qxl.c
> +++ b/hw/display/qxl.c
> @@ -1797,15 +1797,11 @@ static void qxl_send_events(PCIQXLDevice *d, uint32_t
> events)
>
> static void init_pipe_signaling(PCIQXLDevice *d)
> {
> - if (pipe(d->pipe) < 0) {
> - fprintf(stderr, "%s:%s: qxl pipe creation failed\n",
> - __FILE__, __func__);
> + if (qxl_pipe_non_block(d->pipe)) {
Surely this can't compile? -- this function doesn't exist.
thanks
-- PMM
- [Qemu-devel] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block, Alon Levy, 2013/06/04
- [Qemu-devel] [PATCH 3/5] libcacard/vscclient: fix leakage of socket on error paths, Alon Levy, 2013/06/04
- [Qemu-devel] [PATCH 4/5] libcacard/vreader.c: fix possible NULL dereference, Alon Levy, 2013/06/04
- [Qemu-devel] [PATCH 5/5] libcacard/vscclient.c: fix use of uninitialized variable, Alon Levy, 2013/06/04
- Re: [Qemu-devel] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block, Peter Maydell, 2013/06/04
- Re: [Qemu-devel] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block, Eric Blake, 2013/06/04