[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to in
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize |
Date: |
Thu, 06 Jun 2013 21:03:13 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 05/06/2013 05:50, Andreas Färber ha scritto:
> Am 04.06.2013 20:51, schrieb Paolo Bonzini:
>> This series changes all PCI devices (the sole to support hotplug
>> _and_ use MemoryRegions) to do memory_region_del_subregion at
>> unrealize time, and memory_region_destroy at instance_finalize
>> time.
>
> The general idea looks good.
>
> Could you please follow-up with a patch that switches from exit to
> unrealize?
I can add it to the queue, but I have at least 4 pending series.
> Also I notice some patches are accessing parent fields directly - please
> use BUS(), PCI_DEVICE() etc. to hide this.
I'm always using them. For example:
+static void intel_hda_instance_finalize(Object *obj)
+{
+ PCIDevice *pci = PCI_DEVICE(obj);
+ IntelHDAState *d = DO_UPCAST(IntelHDAState, pci, pci);
What I'm not doing, is adding new cast macros---one thing at a time.
Paolo
- Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize, (continued)
- Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize, Peter Maydell, 2013/06/05
- Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize, Michael S. Tsirkin, 2013/06/05
- Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize, Michael S. Tsirkin, 2013/06/05
- Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize, Anthony Liguori, 2013/06/05
- Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize, Michael S. Tsirkin, 2013/06/05
- Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize, Anthony Liguori, 2013/06/05
- Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize, Michael S. Tsirkin, 2013/06/05
- Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize, Peter Maydell, 2013/06/05
Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize,
Paolo Bonzini <=
Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize, Peter Crosthwaite, 2013/06/07
Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize, Andreas Färber, 2013/06/07
Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize, Anthony Liguori, 2013/06/05