[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test
From: |
Peter Chubb |
Subject: |
Re: [Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test |
Date: |
Mon, 10 Jun 2013 09:20:47 +1000 |
User-agent: |
Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.7 (Harue) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/23.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
>>>>> "Stefan" == Stefan Weil <address@hidden> writes:
Stefan> cppcheck detected a condition which was always false.
Stefan> According to the MCIMX31 Reference Manual, the PRCS bits have
Stefan> to be 01 to select the Frequency Pre-Multiplier (FPM). PRCS
Stefan> uses bits 1 and 2, so we have to test for 2.
Good catch. I hate hard coded constants, they're so easy to get wrong!
Stefan> Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Peter Chubb <address@hidden>
--
Dr Peter Chubb peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA