[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-cpu 11/59] monitor: Simplify do_inject_mce()
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH qom-cpu 11/59] monitor: Simplify do_inject_mce() |
Date: |
Mon, 10 Jun 2013 13:14:26 -0400 |
On Sun, 9 Jun 2013 21:12:38 +0200
Andreas Färber <address@hidden> wrote:
> Use qemu_get_cpu() to avoid open-coded CPU loop.
>
> Signed-off-by: Andreas Färber <address@hidden>
Reviewed-by: Luiz Capitulino <address@hidden>
> ---
> monitor.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 6e22d15..19c297d 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2013,7 +2013,6 @@ static void do_acl_remove(Monitor *mon, const QDict
> *qdict)
> static void do_inject_mce(Monitor *mon, const QDict *qdict)
> {
> X86CPU *cpu;
> - CPUX86State *cenv;
> CPUState *cs;
> int cpu_index = qdict_get_int(qdict, "cpu_index");
> int bank = qdict_get_int(qdict, "bank");
> @@ -2026,14 +2025,11 @@ static void do_inject_mce(Monitor *mon, const QDict
> *qdict)
> if (qdict_get_try_bool(qdict, "broadcast", 0)) {
> flags |= MCE_INJECT_BROADCAST;
> }
> - for (cenv = first_cpu; cenv != NULL; cenv = cenv->next_cpu) {
> - cpu = x86_env_get_cpu(cenv);
> - cs = CPU(cpu);
> - if (cs->cpu_index == cpu_index) {
> - cpu_x86_inject_mce(mon, cpu, bank, status, mcg_status, addr,
> misc,
> - flags);
> - break;
> - }
> + cs = qemu_get_cpu(cpu_index);
> + if (cs != NULL) {
> + cpu = X86_CPU(cs);
> + cpu_x86_inject_mce(mon, cpu, bank, status, mcg_status, addr, misc,
> + flags);
> }
> }
> #endif
- Re: [Qemu-devel] [PATCH qom-cpu 07/59] cpus: Simplify set_numa_modes(), (continued)
- [Qemu-devel] [PATCH qom-cpu 08/59] cpus: Simplify qmp_inject_nmi(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 09/59] cpus: Simplify hw_error(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 10/59] cpus: Simplify qemu_tcg_wait_io_event() and qemu_tcg_cpu_thread_fn(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 11/59] monitor: Simplify do_inject_mce(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 12/59] gdbstub: Simplify find_cpu(), Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 14/59] cpus: Change cpu_thread_is_idle() argument to CPUState, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 15/59] cpus: Change qemu_kvm_wait_io_event() argument to CPUState, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 13/59] cpu: Change cpu_exit() argument to CPUState, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 17/59] cpus: Change qemu_kvm_init_cpu_signals() argument to CPUState, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 16/59] kvm: Change kvm_set_signal_mask() argument to CPUState, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 19/59] kvm: Change kvm_handle_internal_error() argument to CPUState, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 20/59] kvm: Change kvm_cpu_exec() argument to CPUState, Andreas Färber, 2013/06/09
- [Qemu-devel] [PATCH qom-cpu 21/59] gdbstub: Set gdb_set_stop_cpu() argument to CPUState, Andreas Färber, 2013/06/09