[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 21/26] ide-test: Add FLUSH CACHE test case
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PULL 21/26] ide-test: Add FLUSH CACHE test case |
Date: |
Mon, 17 Jun 2013 14:45:39 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Jun 14, 2013 at 01:18:44PM -0500, Anthony Liguori wrote:
> Peter Maydell <address@hidden> writes:
>
> > On 14 June 2013 18:54, Peter Maydell <address@hidden> wrote:
> >> On 7 June 2013 12:58, Stefan Hajnoczi <address@hidden> wrote:
> >>> From: Kevin Wolf <address@hidden>
> >>>
> >>> This checks in particular that BSY is set while the flush request is in
> >>> flight.
> >>
> >> This test doesn't seem to pass.
> >
> >> ERROR:/home/petmay01/linaro/qemu-from-laptop/qemu/tests/ide-test.c:460:test_flush:
> >> assertion failed ((data) & (BSY | DF | ERR | DRQ) == 0): (0x00000080
> >> == 0x00000000)
> >
> > ...fixed by http://patchwork.ozlabs.org/patch/250334/
>
> I'm testing it myself now. Since it's already in the block tree, I'll
> push it directly as it's blocking my queue.
>
> Unless Kevin or Stefan are planning on sending a pull request today of
> course.
Thanks for merging mdroth's fix!
Stefan
- [Qemu-devel] [PULL 14/26] qemu-io: Move remaining helpers from cmd.c, (continued)
- [Qemu-devel] [PULL 14/26] qemu-io: Move remaining helpers from cmd.c, Stefan Hajnoczi, 2013/06/07
- [Qemu-devel] [PULL 15/26] qemu-io: Interface cleanup, Stefan Hajnoczi, 2013/06/07
- [Qemu-devel] [PULL 16/26] qemu-io: Use the qemu version for -V, Stefan Hajnoczi, 2013/06/07
- [Qemu-devel] [PULL 17/26] Make qemu-io commands available in HMP, Stefan Hajnoczi, 2013/06/07
- [Qemu-devel] [PULL 18/26] blkdebug: Add BLKDBG_FLUSH_TO_OS/DISK events, Stefan Hajnoczi, 2013/06/07
- [Qemu-devel] [PULL 19/26] ide-test: Add enum value for DEV, Stefan Hajnoczi, 2013/06/07
- [Qemu-devel] [PULL 21/26] ide-test: Add FLUSH CACHE test case, Stefan Hajnoczi, 2013/06/07
[Qemu-devel] [PULL 20/26] ide: Set BSY bit during FLUSH, Stefan Hajnoczi, 2013/06/07
[Qemu-devel] [PULL 22/26] block: add snapshot info query function bdrv_query_snapshot_info_list(), Stefan Hajnoczi, 2013/06/07
[Qemu-devel] [PULL 23/26] block: add image info query function bdrv_query_image_info(), Stefan Hajnoczi, 2013/06/07
[Qemu-devel] [PULL 24/26] qmp: add ImageInfo in BlockDeviceInfo used by query-block, Stefan Hajnoczi, 2013/06/07
[Qemu-devel] [PULL 25/26] hmp: show ImageInfo in 'info block', Stefan Hajnoczi, 2013/06/07
[Qemu-devel] [PULL 26/26] hmp: add parameters device and -v for info block, Stefan Hajnoczi, 2013/06/07
Re: [Qemu-devel] [PULL 00/26] Block patches, Anthony Liguori, 2013/06/17