[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 13/17] ide: Convert SEEK to ide_cmd_table handler
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 13/17] ide: Convert SEEK to ide_cmd_table handler |
Date: |
Tue, 18 Jun 2013 10:26:07 +0200 |
Signed-off-by: Kevin Wolf <address@hidden>
---
hw/ide/core.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 83e86aa..76a3fdf 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -1190,6 +1190,12 @@ static bool cmd_flush_cache(IDEState *s, uint8_t cmd)
return false;
}
+static bool cmd_seek(IDEState *s, uint8_t cmd)
+{
+ /* XXX: Check that seek is within bounds */
+ return true;
+}
+
static bool cmd_read_native_max(IDEState *s, uint8_t cmd)
{
bool lba48 = (cmd == WIN_READ_NATIVE_MAX_EXT);
@@ -1322,7 +1328,7 @@ static const struct {
[WIN_VERIFY] = { cmd_verify, HD_CFA_OK | SET_DSC },
[WIN_VERIFY_ONCE] = { cmd_verify, HD_CFA_OK | SET_DSC },
[WIN_VERIFY_EXT] = { cmd_verify, HD_CFA_OK | SET_DSC },
- [WIN_SEEK] = { NULL, HD_CFA_OK },
+ [WIN_SEEK] = { cmd_seek, HD_CFA_OK | SET_DSC },
[CFA_TRANSLATE_SECTOR] = { NULL, CFA_OK },
[WIN_DIAGNOSE] = { NULL, ALL_OK },
[WIN_SPECIFY] = { cmd_nop, HD_CFA_OK | SET_DSC },
@@ -1409,11 +1415,6 @@ void ide_exec_cmd(IDEBus *bus, uint32_t val)
}
switch(val) {
- case WIN_SEEK:
- /* XXX: Check that seek is within bounds */
- s->status = READY_STAT | SEEK_STAT;
- ide_set_irq(s->bus);
- break;
/* ATAPI commands */
case WIN_PIDENTIFY:
ide_atapi_identify(s);
--
1.8.1.4
- [Qemu-devel] [PATCH 02/17] ide: Convert WIN_DSM to ide_cmd_table handler, (continued)
- [Qemu-devel] [PATCH 02/17] ide: Convert WIN_DSM to ide_cmd_table handler, Kevin Wolf, 2013/06/18
- [Qemu-devel] [PATCH 05/17] ide: Convert verify commands to ide_cmd_table handler, Kevin Wolf, 2013/06/18
- [Qemu-devel] [PATCH 04/17] ide: Convert cmd_nop commands to ide_cmd_table handler, Kevin Wolf, 2013/06/18
- [Qemu-devel] [PATCH 06/17] ide: Convert read/write multiple commands to ide_cmd_table handler, Kevin Wolf, 2013/06/18
- [Qemu-devel] [PATCH 08/17] ide: Convert DMA read/write commands to ide_cmd_table handler, Kevin Wolf, 2013/06/18
- [Qemu-devel] [PATCH 07/17] ide: Convert PIO read/write commands to ide_cmd_table handler, Kevin Wolf, 2013/06/18
- [Qemu-devel] [PATCH 10/17] ide: Convert CHECK POWER MDOE to ide_cmd_table handler, Kevin Wolf, 2013/06/18
- [Qemu-devel] [PATCH 09/17] ide: Convert READ NATIVE MAX ADDRESS to ide_cmd_table handler, Kevin Wolf, 2013/06/18
- [Qemu-devel] [PATCH 11/17] ide: Convert SET FEATURES to ide_cmd_table handler, Kevin Wolf, 2013/06/18
- [Qemu-devel] [PATCH 12/17] ide: Convert FLUSH CACHE to ide_cmd_table handler, Kevin Wolf, 2013/06/18
- [Qemu-devel] [PATCH 13/17] ide: Convert SEEK to ide_cmd_table handler,
Kevin Wolf <=
- [Qemu-devel] [PATCH 14/17] ide: Convert ATAPI commands to ide_cmd_table handler, Kevin Wolf, 2013/06/18
- [Qemu-devel] [PATCH 15/17] ide: Convert CF-ATA commands to ide_cmd_table handler, Kevin Wolf, 2013/06/18
- [Qemu-devel] [PATCH 16/17] ide: Convert SMART commands to ide_cmd_table handler, Kevin Wolf, 2013/06/18
- [Qemu-devel] [PATCH 17/17] ide: Clean up ide_exec_cmd(), Kevin Wolf, 2013/06/18
- Re: [Qemu-devel] [PATCH 00/17] ide: Use ide_cmd_table function pointers for command execution, Stefan Hajnoczi, 2013/06/19