[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH resend] pci-assign: remove the duplicate functio
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH resend] pci-assign: remove the duplicate function name in debug message |
Date: |
Wed, 19 Jun 2013 15:04:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 19/06/2013 05:18, Wanlong Gao ha scritto:
> While DEBUG() already includes the function name.
>
> Signed-off-by: Wanlong Gao <address@hidden>
> Acked-by: Alex Williamson <address@hidden>
> ---
> hw/i386/kvm/pci-assign.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
> index ff85590..9896c28 100644
> --- a/hw/i386/kvm/pci-assign.c
> +++ b/hw/i386/kvm/pci-assign.c
> @@ -226,7 +226,7 @@ static uint32_t slow_bar_readb(void *opaque, hwaddr addr)
> uint32_t r;
>
> r = *in;
> - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
>
> return r;
> }
> @@ -238,7 +238,7 @@ static uint32_t slow_bar_readw(void *opaque, hwaddr addr)
> uint32_t r;
>
> r = *in;
> - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
>
> return r;
> }
> @@ -250,7 +250,7 @@ static uint32_t slow_bar_readl(void *opaque, hwaddr addr)
> uint32_t r;
>
> r = *in;
> - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
>
> return r;
> }
> @@ -260,7 +260,7 @@ static void slow_bar_writeb(void *opaque, hwaddr addr,
> uint32_t val)
> AssignedDevRegion *d = opaque;
> uint8_t *out = d->u.r_virtbase + addr;
>
> - DEBUG("slow_bar_writeb addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr,
> val);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr, val);
> *out = val;
> }
>
> @@ -269,7 +269,7 @@ static void slow_bar_writew(void *opaque, hwaddr addr,
> uint32_t val)
> AssignedDevRegion *d = opaque;
> uint16_t *out = (uint16_t *)(d->u.r_virtbase + addr);
>
> - DEBUG("slow_bar_writew addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr,
> val);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr, val);
> *out = val;
> }
>
> @@ -278,7 +278,7 @@ static void slow_bar_writel(void *opaque, hwaddr addr,
> uint32_t val)
> AssignedDevRegion *d = opaque;
> uint32_t *out = (uint32_t *)(d->u.r_virtbase + addr);
>
> - DEBUG("slow_bar_writel addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr,
> val);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, val);
> *out = val;
> }
>
>
Applied to uq/master, thanks.
Paolo